Skip to content

impl: visual text progress during Coder CLI downloading #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

fioan89
Copy link
Collaborator

@fioan89 fioan89 commented Jun 12, 2025

This PR implements a mechanism to provide recurrent stats about the number of the KB and MB of Coder CLI downloaded.

fioan89 added 3 commits June 13, 2025 00:21
The REST client doesn't do any authentication but rather
retrieves the user and build info - the user is already
authenticated via the API token. So `authenticate` is misleading here.
This PR implements a mechanism to provide recurrent stats about
the number of the KB and MB of Coder CLI downloaded.
@fioan89 fioan89 requested review from matifali and f0ssel June 12, 2025 22:42
Keeps the previous behavior which was removing the binary before download.
@fioan89 fioan89 marked this pull request as ready for review June 17, 2025 19:43
@fioan89
Copy link
Collaborator Author

fioan89 commented Jun 17, 2025

This is how the download progress looks like.

image
image

Screen.Recording.2025-06-17.at.23.12.36.mov

@fioan89
Copy link
Collaborator Author

fioan89 commented Jun 17, 2025

@matifali I was thinking that we should also change the title from Authenticate to Coder to Setting up Coder on all three pages, on the same premise that we don't do any authenticatio. What are your thoughts?

@matifali
Copy link
Member

We also don't do any setting up.
What we do is to download the newer alim CLI binary if available.
So maybe download CLi and show the version and progress bar.

@fioan89
Copy link
Collaborator Author

fioan89 commented Jun 18, 2025

We also don't do any setting up. What we do is to download the newer alim CLI binary if available. So maybe download CLi and show the version and progress bar.

We download the cli, we initialize the cli with the token, re-generate the ssh config file, initialize a rest client with the deployment url and the token and retrieve basic information about the deployment like the version and the user authenticated by the token. The three pages wizard from the video needs a title which is why I proposed to compress all of the steps I just mentioned in a "Setting up Coder" title. I'm open for any suggestions regarding the title.

@fioan89
Copy link
Collaborator Author

fioan89 commented Jun 18, 2025

@matifali what do you think?

image

Screen.Recording.2025-06-18.at.23.05.46.mp4

fioan89 added 4 commits June 18, 2025 23:14
Alongside the content size downloaded
We are not really doing authentication, instead we download the cli,
we initialize the cli with the token, re-generate the ssh config file,
initialize a rest client with the deployment url and the token and
retrieve basic information about the deployment like the version and
the user authenticated by the token.
@fioan89
Copy link
Collaborator Author

fioan89 commented Jun 18, 2025

improved flow.

Screen.Recording.2025-06-18.at.23.36.46.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants